FE: Messages: Implement messages export #740
Conversation
kapybro
bot
added
status/triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi alexanderlz! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
Haarolean
added
type/enhancement
|
definitely (both of your questions). Happy New Year! |
likewise, happy new year 😊 |
frontend/src/components/Topics/Topic/Messages/MessagesTable.tsx
Outdated
Show resolved
Hide resolved
frontend/src/components/Topics/Topic/Messages/MessagesTable.tsx
Outdated
Show resolved
Hide resolved
content -> value
Indeed, but if you'd look up 'export icon' it'd yield the opposite one. @snoorge's point:
I have to agree with @snoorge here, however it's kinda counter intuitive. |
Fair enough. I have also seen it like this to differentiate it from a upload 
I think that at some point in the future, we may want to add "upload" or "import" into Kafka which would be a very similar icon and maybe even more confusing In this case, we have text along with the icon, and I think that the icon is not as important here. Both points can be made |
|
tl;dr - we change the icon or leave it as is? |
Based on the comments above, it seems that @Haarolean is looking to implement it as the original design intended and not what I suggested. But @Haarolean can confirm Apologies for the back and forth @alexanderlz , it was my opinion and not final. I appreciate your efforts :) |
new look. |
|
I approved it but there is a linting problem that you may need to resolve before this is merged |
alexanderlz
force-pushed
the
issues/688
branch
2 times, most recently
from
ebb9188 to
b168638
Compare
There was a problem hiding this comment.
Can we use the export icon provided with the design reference?
github-project-automation
bot
moved this from In Development
to Changes requested
in Release 1.4
alexanderlz
force-pushed
the
issues/688
branch
2 times, most recently
from
88579f2 to
08f0967
Compare
@Haarolean replaced. |
| viewBox="0 0 18 18" | ||
| fill="currentColor" | ||
| > | ||
| <path d="M4.24 5.8a.75.75 0 001.06-.04l1.95-2.1v6.59a.75.75 0 001.5 0V3.66l1.95 2.1a.75.75 0 101.1-1.02l-3.25-3.5a.75.75 0 00-1.101.001L4.2 4.74a.75.75 0 00.04 1.06z" /> |
There was a problem hiding this comment.
Can we please extract this icon like others into a separate file/class in src/components/common/Icons?
| }} | ||
| > | ||
| <svg | ||
| width="24" |
There was a problem hiding this comment.
Could you adjust the size please?
What changes did you make? (Give an overview)
Added an option to download all messages that are displayed on page(as csv or json)
as per #688
useDataSaver method is reused here.
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
